Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development into main #672

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Merge development into main #672

merged 2 commits into from
Jan 16, 2025

Conversation

louis-md
Copy link
Collaborator

No description provided.

yagopv and others added 2 commits December 10, 2024 14:40
* Write tutorial

* Upload GIF

* Some improvements

* Update image

* Vale

* Some improvements

* Some improvements

* Some fixes and improvements

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Update pages/advanced/passkeys/tutorials/react-native.mdx

* Add react-native-passkeys tutorial to generateCodeExamples.js script

* Switch generateCodeExamples.js to TypeScript

* Run generateCodeExamples.ts

* Add Xcode to Vale whitelist

* Import style changes from tutorial repo

* Implement requested changes

* Implement requested changes

* Fix vale errors

* Revert requested change l.93 and fix formatting issue

* Fix instructions for iOS

* Reupload iOS assets

* Fix typo

* Add app.json to the code examples

* Streamline iOS flow; implement requested changes

* Fix typo

---------

Co-authored-by: louis-md <[email protected]>
Copy link

github-actions bot commented Jan 16, 2025

Branch preview

✅ Deployed successfully in branch deployment:

https://development--docs.review.5afe.dev

Copy link

Overall readability score: 30.91 (🔴 -0.4)

File Readability
react-native.mdx 64.19 (-)
createpasskeysigner.mdx 60.13 (-)
passkeys.mdx 34.42 (🟢 +7.73)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
react-native.mdx 64.19 54.52 9.96 11 10.9 7.18
  - - - - - -
createpasskeysigner.mdx 60.13 53.88 7.3 11 14 8.47
  - - - - - -
passkeys.mdx 34.42 39.4 16.02 20.3 11.21 8.09
  🟢 +7.73 🟢 +4.46 🟢 +1.71 🟢 +1.7 🔴 -0.17 🟢 +0.57

Averages:

  Readability FRE GF ARI CLI DCRS
Average 30.91 26.94 13.63 17.74 15.81 8.96
  🔴 -0.4 🔴 -0.34 🟢 +0.08 🔴 -0.3 🔴 -0.07 🟢 +0.02
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@louis-md louis-md merged commit 5cd9582 into main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants